Fix #110: Handle WebSocket close events #111
Conversation
Current coverage is 100% (diff: 100%)@@ develop #111 diff @@
=====================================
Files 15 15
Lines 1522 1532 +10
Methods 258 260 +2
Messages 0 0
Branches 393 395 +2
=====================================
+ Hits 1522 1532 +10
Misses 0 0
Partials 0 0
|
| * @param {number} reconnectionDelay | ||
| * @param {string|Object} message | ||
| */ | ||
| function onClientError(autoReconnect, reconnectionDelay, message) { |
There was a problem hiding this comment.
isn't it possible to factorize a little bit the code btw. wsbrowsers.js and wsnode.js ?
(as far as I can see, only the code of this.connect() method has some differences in its syntax)
There was a problem hiding this comment.
It should be, I separated the two wrappers because I initially thought that there would be more differences than that.
Right now the biggest problem is with webpack, when it tries to package ws and other modules that are incompatible with web browsers (crypto and bufferutil).
The only solution I found was to exclude wsnode.js from webpack's analysis. We need to find some way to factorize wsnode and wsbrowsers while preventing webpack to include these modules.
|
+1 |
4 participants
Now checks the connection close event code and calls the onError listeners instead of the onDisconnect ones when appropriate.