Skip to content

Do not logout on kuzzle.disconnect #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Do not logout on kuzzle.disconnect #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac0fed
remove logout from disconnect
Oct 3, 2016
ce97758
Merge remote-tracking branch 'origin/develop' into disconnect-logout
Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/kuzzle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,8 +1032,6 @@ Kuzzle.prototype.listIndexes = function (options, cb) {
Kuzzle.prototype.disconnect = function () {
var collection;

this.logout();

this.state = 'disconnected';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you want to put a condition here based on an argument?

Copy link
Contributor Author

@AnthonySendra AnthonySendra Oct 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick discussion with @scottinet and @jenow, we decided if the user wants to logout, he can directly call kuzzle.logout() explicitely.

this.network.close();
this.network = null;
Expand Down