use 7512 port by default for both websocket and socketio #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix documentation and default config to use 7512 port for both websocket and socketio protocols
Codecov Report@@ Coverage Diff @@
## develop #180 +/- ##
===========================================
- Coverage 99.39% 99.33% -0.07%
===========================================
Files 16 16
Lines 1662 1661 -1
Branches 441 440 -1
===========================================
- Hits 1652 1650 -2
- Misses 10 11 +1
Continue to review full report at Codecov.
|
ballinette
pushed a commit
to kuzzleio/kuzzle-admin-console
that referenced
this pull request
Feb 9, 2017
…io/sdk-javascript#180: Use now the same port (`7512`) for both websocket and socketio protocols
dbengsch
approved these changes
Feb 9, 2017
xbill82
approved these changes
Feb 9, 2017
scottinet
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://github.com/kuzzleio/kuzzle-proxy/pull/48
Now, Kuzzle will listen to the same port for both protocols.
This fixes the default config as well as the documentation.
TODO after merging this PR: "un-wip" the related PR on Backoffice: kuzzleio/kuzzle-admin-console#213 (+ update the sdk version dependency into it)