Skip to content

Conversation

scottinet
Copy link
Contributor

Description

Following kuzzleio/kuzzle#709, the scroll option is now optional (!)
Also fix the way the query is built to make it consistent with the way kuzzle.query is meant to be used.

@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@3c3150f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage          ?   99.45%           
=========================================
  Files             ?       16           
  Lines             ?     1663           
  Branches          ?      440           
=========================================
  Hits              ?     1654           
  Misses            ?        9           
  Partials          ?        0
Impacted Files Coverage Δ
src/Collection.js 97.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3150f...5deb313. Read the comment docs.

@scottinet scottinet self-assigned this Mar 8, 2017
@scottinet scottinet merged commit 9622fe6 into master Mar 9, 2017
@scottinet scottinet deleted the fix-scroll-method branch March 9, 2017 13:30
@scottinet scottinet restored the fix-scroll-method branch March 9, 2017 13:30
@scottinet scottinet deleted the fix-scroll-method branch March 9, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants