Added all new credential related routes #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Kuzzle.js
Codecov Report
@@ Coverage Diff @@
## 4.x #217 +/- ##
======================================
Coverage ? 99.45%
======================================
Files ? 16
Lines ? 1845
Branches ? 529
======================================
Hits ? 1835
Misses ? 10
Partials ? 0
Continue to review full report at Codecov.
|
dbengsch
approved these changes
May 12, 2017
benoitvidis
approved these changes
May 15, 2017
xbill82
reviewed
May 16, 2017
| * @param cb | ||
| * @returns {Security} | ||
| */ | ||
| Security.prototype.createCredentials = function (strategy, kuid, credentials, options, cb) { |
| * @param cb | ||
| * @returns {Security} | ||
| */ | ||
| Security.prototype.deleteCredentials = function (strategy, kuid, options, cb) { |
There was a problem hiding this comment.
This applies to all the following methods that accept strategy as the first argument.
There was a problem hiding this comment.
Then kuzzle wil answer an error
There was a problem hiding this comment.
ok then we assume that we leave the responsibility to Kuzzle. Approving.
xbill82
approved these changes
May 17, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of new actions in auth controller:
Creation of new actions in security controller: