Allow creating a user without specifying the id #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should do the same for |
|
@xbill82 did you check other SDKs as well ? |
|
@dbengsch yep, the Android needs the same fix |
jenow
approved these changes
Jun 20, 2017
|
Ok @samniisan things should be fixed now! |
Codecov Report
@@ Coverage Diff @@
## 5.x #229 +/- ##
==========================================
+ Coverage 98.41% 98.45% +0.04%
==========================================
Files 17 17
Lines 2144 2140 -4
Branches 610 608 -2
==========================================
- Hits 2110 2107 -3
+ Misses 34 33 -1
Continue to review full report at Codecov.
|
scottinet
approved these changes
Jun 27, 2017
|
Waiting for this PR to be created on the Android SDK project to merge this one. |
benoitvidis
approved these changes
Jun 27, 2017
samniisan
approved these changes
Jun 28, 2017
stafyniaksacha
approved these changes
Jun 30, 2017
Merged
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligning the API to the core. The ID is no longer mandatory to create a user, since Kuzzle auto-generates one.