Skip to content

Conversation

scottinet
Copy link
Contributor

  • MS functions returning either 0 or 1 are now resolving to a boolean value instead of an integer
  • MS functions returning "OK" now resolves to a function (err, undefined) callback (or an empty thenable when promisified)

@scottinet scottinet self-assigned this Nov 10, 2017
@codecov-io
Copy link

codecov-io commented Nov 10, 2017

Codecov Report

Merging #258 into 6.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              6.x     #258      +/-   ##
==========================================
+ Coverage   98.59%   98.59%   +<.01%     
==========================================
  Files          17       17              
  Lines        2134     2136       +2     
  Branches      618      618              
==========================================
+ Hits         2104     2106       +2     
  Misses         30       30
Impacted Files Coverage Δ
src/MemoryStorage.js 99.05% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb62939...71b29f8. Read the comment docs.

@scottinet scottinet merged commit 214d0a3 into 6.x Nov 21, 2017
@scottinet scottinet deleted the harmonize_ms_retval branch November 21, 2017 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants