-
Notifications
You must be signed in to change notification settings - Fork 17
Fix exposed object properties #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x #259 +/- ##
==========================================
- Coverage 98.59% 98.32% -0.27%
==========================================
Files 17 17
Lines 2134 2210 +76
Branches 618 645 +27
==========================================
+ Hits 2104 2173 +69
- Misses 30 37 +7
Continue to review full report at Codecov.
|
ballinette
approved these changes
Nov 21, 2017
Merged
benoitvidis
approved these changes
Nov 29, 2017
ballinette
pushed a commit
that referenced
this pull request
Dec 4, 2017
ballinette
pushed a commit
that referenced
this pull request
Dec 4, 2017
ballinette
pushed a commit
that referenced
this pull request
Dec 4, 2017
ballinette
pushed a commit
that referenced
this pull request
Dec 18, 2017
ballinette
pushed a commit
that referenced
this pull request
Feb 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Room
object:roomId
is now a read-only property, and is not used as an internal flag to check if a subscription is active. Instead, a new privateactive
boolean property has been added for that purposescope
,state
andusers
are now enumerableautoResubscribe
is now read-only, as is the same property from the Kuzzle main objectheaders
property from all objects