Skip to content

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Nov 21, 2017

Description

  • expose the missing object properties expected by the current SDK specifications, with the right read/write attributes
    • kuzzle object:
      • autoQueue (writable)
      • autoReconnect (changed to read-only)
      • autoReplay (writable)
      • host (read-only)
      • offlineQueue (changed to read-only)
      • offlineQueueLoader (writable)
      • port (read-only)
      • queueFilter (writable)
      • queueMaxSize (writable)
      • queueTTL (writable)
      • replayInterval (writable)
      • reconnectionDelay (changed to read-only)
      • sslConnection (read-only)
    • Room object:
      • roomId is now a read-only property, and is not used as an internal flag to check if a subscription is active. Instead, a new private active boolean property has been added for that purpose
      • scope, state and users are now enumerable
      • autoResubscribe is now read-only, as is the same property from the Kuzzle main object
  • remove the now obsolete headers property from all objects

@codecov-io
Copy link

codecov-io commented Nov 21, 2017

Codecov Report

Merging #259 into 6.x will decrease coverage by 0.26%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##              6.x     #259      +/-   ##
==========================================
- Coverage   98.59%   98.32%   -0.27%     
==========================================
  Files          17       17              
  Lines        2134     2210      +76     
  Branches      618      645      +27     
==========================================
+ Hits         2104     2173      +69     
- Misses         30       37       +7
Impacted Files Coverage Δ
src/Document.js 98.97% <ø> (-0.05%) ⬇️
src/CollectionMapping.js 97.56% <100%> (-0.17%) ⬇️
src/Collection.js 100% <100%> (ø) ⬆️
src/Room.js 100% <100%> (ø) ⬆️
src/networkWrapper/protocols/abstract/realtime.js 98.63% <100%> (-0.69%) ⬇️
src/MemoryStorage.js 99.42% <100%> (+0.38%) ⬆️
src/Kuzzle.js 97.44% <88.88%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb62939...21eaf6d. Read the comment docs.

@scottinet scottinet mentioned this pull request Nov 28, 2017
@benoitvidis benoitvidis merged commit ad5e54f into 6.x Nov 29, 2017
@benoitvidis benoitvidis deleted the missing_getters_setters branch November 29, 2017 11:44
@scottinet scottinet restored the missing_getters_setters branch November 29, 2017 12:24
ballinette pushed a commit that referenced this pull request Dec 4, 2017
ballinette pushed a commit that referenced this pull request Dec 4, 2017
ballinette pushed a commit that referenced this pull request Dec 4, 2017
ballinette pushed a commit that referenced this pull request Dec 18, 2017
@scottinet scottinet deleted the missing_getters_setters branch December 19, 2017 16:13
ballinette pushed a commit that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants