Fix network events #261
Merged
Fix network events #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x #261 +/- ##
==========================================
+ Coverage 98.25% 98.25% +<.01%
==========================================
Files 17 17
Lines 2125 2126 +1
Branches 618 618
==========================================
+ Hits 2088 2089 +1
Misses 37 37
Continue to review full report at Codecov.
|
ballinette
approved these changes
Nov 29, 2017
scottinet
changed the title
benoitvidis
approved these changes
Dec 4, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event 'tokenExpired'
The
unsetJwtmethod being public, it's not a good idea to make it trigger thetokenExpiredevent when called. Furthermore it's not its role to propagate that event.This SDK makes the Kuzzle main object contructor itself subscribe to the network layer
tokenExpiredevent and takes responsability to propagate it. The event itself is also propagated by the generic notification callback layer, in case the token expires while no new request is made'disconnected' state
Upon disconnection, both
socket.ioandwebsocketprotocol implementations set the network set todisconnectedinstead ofoffline, making all further calls tokuzzle.connect()impossible with that instance