-
Notifications
You must be signed in to change notification settings - Fork 17
Remove auto connect #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove auto connect #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x #266 +/- ##
==========================================
+ Coverage 98.27% 98.46% +0.18%
==========================================
Files 17 17
Lines 2140 2079 -61
Branches 623 604 -19
==========================================
- Hits 2103 2047 -56
+ Misses 37 32 -5
Continue to review full report at Codecov.
|
ballinette
approved these changes
Dec 11, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the ability to connect automatically from Kuzzle's main object constructor:
kuzzle.connect()
: the constructor does not take a callback anymore, butconnect
doeskuzzle.connect
can now be promisified intokuzzle.connectPromise
, as many users expected from reading our documentationkuzzle.connect
now returns nothing, as it makes no sense chaining calls on an asynchronous network connection methodNote: a documentation update will be submitted shortly