Allow passing a custom network object to Kuzzle SDK constructor #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See KZL-175
Change the signature of SDK constructor to match actual signature in Go SDK and enable developers to instantiate the SDK with their custom network protocol:
Other changes
Expose also
AbstractNetwork
andKuzzleEventEmitter
:Thus, custom protocol can easily inherits from
AbstractNetwork
and only implementsconnect
andsend
methods:Another way to implement a custom protocol is to implement
isReady
andquery
methods, as well as javascript Event API:Boyscout
Some minor cosmetic changes in network wrappers code.