Fix document save when no id provided #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #304 +/- ##
==========================================
+ Coverage 98.34% 98.34% +<.01%
==========================================
Files 17 17
Lines 2118 2119 +1
==========================================
+ Hits 2083 2084 +1
Misses 35 35
Continue to review full report at Codecov.
|
Njuelle
approved these changes
Aug 9, 2018
ballinette
approved these changes
Aug 9, 2018
scottinet
added a commit
that referenced
this pull request
Sep 13, 2018
* collection.create can be used with a mapping * move eslint-loader to devDependencies * update to webpack 4 * remove useless call to removeAllListeners * mappings should be send inside a "body" property * Fix document save when no id provided (#304) * Allow to save document without ID * fix eslint * fix sinon * Release 5.0.13 * dependencies update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When calling
document.save()the SDK make acreateOrReplacequery to Kuzzle.If the document was created without
id, the query will fail.This PR allow
save()to call thecreateaction instead ofcreateOrReplacewhen noidis provided.Fix: #303
How should this be manually tested?
curl -X POST localhost:7512/test/_create && curl -X POST localhost:7512/test/test/_createkuzzle.collection('test', 'test').document({gordon: 'freeman'}).savePromise()