Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Oct 8, 2018

What does this PR do?

This PR fix the return value for index#list and index#mDelete.
They now returns array of strings instead of an object containing only one property.

How should this be manually tested?

  • Step 1 : Create some indexes for i in {1..10}; do; curl -H "Content-Type: application/json" -X POST "http://localhost:7512/test$i/_create" &; sleep 0.05; done
  • Step 2 : List them await kuzzle.index.list() and check return value
  • Step 3 : Delete them `await kuzzle.index.mDelete(['test1', 'test2']) and check return value

@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #320 into 6-dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           6-dev    #320   +/-   ##
=====================================
  Coverage   97.5%   97.5%           
=====================================
  Files         28      28           
  Lines       1400    1400           
=====================================
  Hits        1365    1365           
  Misses        35      35
Impacted Files Coverage Δ
src/controllers/index.js 97.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7d805...92f9020. Read the comment docs.

@ScreamZ
Copy link
Contributor

ScreamZ commented Oct 8, 2018

Nice one

@alexandrebouthinon alexandrebouthinon merged commit 01ff73a into 6-dev Oct 10, 2018
@alexandrebouthinon alexandrebouthinon deleted the fix-index-list-and-mdelete-return branch October 10, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants