Skip to content

Conversation

benoitvidis
Copy link
Contributor

This PR slightly modifies the SearchResult objects by

  • (cosmetic) making internal properties pseudo-private to get a more readable console.log
  • add the aggregations support

@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #323 into 6-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           6-dev    #323      +/-   ##
========================================
+ Coverage   97.5%   97.5%   +<.01%     
========================================
  Files         28      28              
  Lines       1400    1404       +4     
========================================
+ Hits        1365    1369       +4     
  Misses        35      35
Impacted Files Coverage Δ
src/controllers/searchResult/profile.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/document.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/base.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/role.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/user.js 100% <100%> (ø) ⬆️
src/controllers/searchResult/specifications.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428cace...4b22e50. Read the comment docs.

@jenow jenow merged commit 1e54073 into 6-dev Oct 22, 2018
@jenow jenow deleted the SearchResult-pseudo-private branch October 22, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants