Fix bug in room notifications with multiple subscribes on same filter #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
approved these changes
Oct 31, 2018
alexandrebouthinon
approved these changes
Oct 31, 2018
Codecov Report
@@ Coverage Diff @@
## 5-dev #334 +/- ##
==========================================
+ Coverage 98.34% 98.34% +<.01%
==========================================
Files 17 17
Lines 2119 2120 +1
==========================================
+ Hits 2084 2085 +1
Misses 35 35
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The notificationCallback which is called on a Document notification alter the input parameter while it is called.
Consequently, if it is called more than 1 time (especially if we subscribed 2 times to the same filter), the first call will modifiy this parameter, and the second call will crash.
This PR fix that.
How should this be manually tested?