Skip to content

Conversation

benoitvidis
Copy link
Contributor

@benoitvidis benoitvidis commented Nov 8, 2018

⚠️ depends on #327

Elasticsearch scroll method does not accept any other parameter than the scrollId. This PR only sends the proper parameters to the method.

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #335 into 6-dev will decrease coverage by 0.2%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #335      +/-   ##
==========================================
- Coverage   97.49%   97.28%   -0.21%     
==========================================
  Files          28       28              
  Lines        1395     1401       +6     
==========================================
+ Hits         1360     1363       +3     
- Misses         35       38       +3
Impacted Files Coverage Δ
src/controllers/searchResult/base.js 94.33% <75%> (-5.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74dff7...d4854fb. Read the comment docs.

@alexandrebouthinon alexandrebouthinon merged commit 2386fa8 into 6-dev Nov 8, 2018
@alexandrebouthinon alexandrebouthinon deleted the searchResult-next-2 branch November 8, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants