Skip to content

Conversation

Njuelle
Copy link
Contributor

@Njuelle Njuelle commented Jan 4, 2019

What does this PR do?

Just add npm prepublish script to build dist before publish on npm to be able to use the sdk from a CDN (jsdelivr)

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #352 into 6-beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           6-beta     #352   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          27       27           
  Lines        1397     1397           
=======================================
  Hits         1349     1349           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee6f71...76f48b4. Read the comment docs.

Copy link
Member

@etrousset etrousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💯

@Aschen Aschen merged commit df42fa2 into 6-beta Jan 4, 2019
@Aschen Aschen deleted the add-prepulish-script branch January 4, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants