Skip to content

Conversation

xbill82
Copy link
Contributor

@xbill82 xbill82 commented Jan 14, 2019

Fixes a call to checkToken upon reconnection to Kuzzle. The previous version was surely a copy/paste error based on v5.

How should this be manually tested?

  • connect to Kuzzle
  • add a listener on the reconnected event
  • disconnect from Kuzzle (one way to do it is to docker-compose stop kuzzle)
  • reconnect to Kuzzle
  • the callback attached to your listened should be triggered

@xbill82 xbill82 self-assigned this Jan 14, 2019
@xbill82 xbill82 requested a review from scottinet January 14, 2019 16:39
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a unit test?

@xbill82
Copy link
Contributor Author

xbill82 commented Jan 15, 2019

@scottinet yep, sorry I forgot to add the WIP tag... Just added the test!

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #359 into 6-dev will decrease coverage by 0.13%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #359      +/-   ##
==========================================
- Coverage   96.59%   96.45%   -0.14%     
==========================================
  Files          28       28              
  Lines        1409     1411       +2     
==========================================
  Hits         1361     1361              
- Misses         48       50       +2
Impacted Files Coverage Δ
src/Kuzzle.js 94.93% <75%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f91d5b...73987ea. Read the comment docs.

@etrousset etrousset merged commit a0f419e into 6-dev Jan 15, 2019
@etrousset etrousset deleted the FIX-checktoken-after-reconnect branch January 15, 2019 12:24
@scottinet scottinet mentioned this pull request Jan 17, 2019
scottinet pushed a commit that referenced this pull request Jan 17, 2019
Fixes a call to `checkToken` upon reconnection to Kuzzle. The previous version was surely a copy/paste error based on v5.
@scottinet scottinet mentioned this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants