[es7] remove async/await #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballinette
approved these changes
Feb 6, 2019
alexandrebouthinon
approved these changes
Feb 6, 2019
Codecov Report
@@ Coverage Diff @@
## 6-dev #368 +/- ##
=========================================
+ Coverage 96.6% 96.61% +<.01%
=========================================
Files 28 28
Lines 1415 1417 +2
=========================================
+ Hits 1367 1369 +2
Misses 48 48
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Babel.js is not able to handle the async/await feature without a polyfill to be included along with the SDK on production.
Forcing the use of a polyfill is not a desired outcome for our SDK, so async/await is now a banned feature.
How-to test
The "raw web" getting started tests are currently failing on the documentation because of this problem. Using this branch version solve the failing test.