Skip to content

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Jul 1, 2019

What does this PR do?

Make createUser id parametre optional as it is in the API.

How should this be manually tested?

kuzzle.security.createUser(null, {
    content: {
      profileIds: ['default']
    },
    credentials: {
      local: {
        username: 'auto',
        password: 'auto'
      }
    }
  });

It should create a user with a generated id.

@jenow jenow self-assigned this Jul 1, 2019
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #408 into 6-dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            6-dev    #408      +/-   ##
=========================================
- Coverage   96.31%   96.3%   -0.01%     
=========================================
  Files          32      32              
  Lines        1519    1517       -2     
=========================================
- Hits         1463    1461       -2     
  Misses         56      56
Impacted Files Coverage Δ
src/controllers/security/index.js 99.58% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44bb6b...cd220fd. Read the comment docs.

@xbill82 xbill82 changed the title Make createUser id parametre optional Make createUser id parameter optional Jul 1, 2019
@xbill82 xbill82 merged commit 35b1532 into 6-dev Jul 1, 2019
@xbill82 xbill82 deleted the optional-id-create-user branch July 1, 2019 09:28
@Aschen Aschen mentioned this pull request Jul 1, 2019
scottinet pushed a commit to kuzzleio/kuzzle-admin-console that referenced this pull request Jul 5, 2019
## What does this PR do ?

fix #553 where we could not create a user without id by updating kuzzle sdk (kuzzleio/sdk-javascript#408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants