Prevent pending request leak when disconnect the SDK #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6-dev #424 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.02%
==========================================
Files 32 32
Lines 1520 1529 +9
==========================================
+ Hits 1464 1473 +9
Misses 56 56
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 6-dev #424 +/- ##
=========================================
+ Coverage 96.31% 96.41% +0.1%
=========================================
Files 32 32
Lines 1520 1535 +15
=========================================
+ Hits 1464 1480 +16
+ Misses 56 55 -1
Continue to review full report at Codecov.
|
Yoann-Abbes
reviewed
Jul 16, 2019
| * Emits an event for each discarded pending request. | ||
| */ | ||
| clear () { | ||
| for (const request of this._pendingRequests.values()) { |
There was a problem hiding this comment.
I try to avoid forEach because it's error prone when dealing with promise. I could use it here but I prefer to stick to the same construct everywhere
Yoann-Abbes
approved these changes
Jul 17, 2019
scottinet
approved these changes
Jul 17, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Jul 31, 2019
# [6.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.2.0) (2019-07-31) #### Bug fixes - [ [#428](#428) ] Properly handle boolean flags in HTTP querystrings ([scottinet](https://github.com/scottinet)) - [ [#427](#427) ] Solve promise+event+memory leaks when the network fails ([scottinet](https://github.com/scottinet)) - [ [#424](#424) ] Prevent pending request leak when disconnect the SDK ([Aschen](https://github.com/Aschen)) - [ [#422](#422) ] Fix bug when decoding JWT in browser ([Aschen](https://github.com/Aschen)) - [ [#420](#420) ] Fix http protocol unresolved promise on connection error ([Aschen](https://github.com/Aschen)) #### New features - [ [#419](#419) ] Add bulk:write and bulk:mWrite ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#421](#421) ] Get api routes from server:publicApi ([Aschen](https://github.com/Aschen)) - [ [#423](#423) ] Emit queryError event on malformed request ([Aschen](https://github.com/Aschen)) - [ [#417](#417) ] Security controller documentation ([benoitvidis](https://github.com/benoitvidis)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a request is made to Kuzzle, we setup a once listener to handle the response. If a disconnection occur (manual with
disconnect()or not), the listener are never freed.This PR save the pending requests in a
Mapand when a disconnection occur, adiscardedevent is triggered for each requests and then the map is cleared.Fix #356
Other changes