Add timeout support to Http protocol #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6-dev #439 +/- ##
=========================================
- Coverage 96.15% 96.1% -0.06%
=========================================
Files 33 33
Lines 1612 1616 +4
=========================================
+ Hits 1550 1553 +3
- Misses 62 63 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 6-dev #439 +/- ##
=========================================
- Coverage 96.15% 96.1% -0.06%
=========================================
Files 33 33
Lines 1612 1616 +4
=========================================
+ Hits 1550 1553 +3
- Misses 62 63 +1
Continue to review full report at Codecov.
|
scottinet
suggested changes
Aug 8, 2019
| | `port` | <pre>number</pre><br/>(`7512`) | Kuzzle server port | | ||
| | `sslConnection` | <pre>boolean</pre><br/>(`false`) | Use SSL to connect to Kuzzle server | | ||
| | `customRoutes` | <pre>object</pre><br/>(`{}`) | Add custom routes <SinceBadge version="6.2.0"/> | | ||
| | `timeout` | <pre>number</pre><br/>(`0`) | Connection timeout <SinceBadge version="6.2.1"/> | |
There was a problem hiding this comment.
What's the unit? And does '0' mean "no timeout"?
| | `port` | <pre>number</pre> | Kuzzle server port | Get | | ||
| | `protocol` | <pre>string</pre> | `https` or `http` | Get | | ||
| | `ssl` | <pre>boolean</pre> | `true` if ssl is active | Get | | ||
| | `timeout` | <pre>number</pre> | Connection timeout <SinceBadge version="6.2.1"/>| Get/Set | |
alexandrebouthinon
approved these changes
Aug 8, 2019
scottinet
suggested changes
Aug 9, 2019
Co-Authored-By: Sébastien Cottinet <[email protected]>
scottinet
approved these changes
Aug 9, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Sep 11, 2019
# [6.2.2](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.2.2) (2019-09-11) #### Bug fixes - [ [#437](#437) ] Fix duplicate subscriptions on reconnect ([benoitvidis](https://github.com/benoitvidis)) #### Enhancements - [ [#439](#439) ] Add timeout support to Http protocol ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a connection timeout for http protocol
https://deploy-preview-439--doc-sdk-javascript.netlify.com/protocols/http/properties/
How should this be manually tested?
new Http('localhost', { timeout: 1000 })