Skip to content

Conversation

@berthieresteban
Copy link
Contributor

@berthieresteban berthieresteban commented Feb 21, 2020

What does this PR do?

Fix links for getting started react, react native, vuejs for sdk JS 7.
Les liens vers /core/2 ne seront pas accessible depuis le build netlify qui ne charge que les pages de doc du sdkl
Le test concernant les deadlink est pété d'ou le fail
(ex: src/controllers/auth/login in src/sdk/js/7//getting-started/react-native/index.md)
ce lien fonctionne sur netlify

How should this be manually tested?

Netlify

Other changes

/

Boyscout

Remove link to react kuzzle boilerplate in getting started react because it is not up to date with kuzzle versions

@berthieresteban berthieresteban self-assigned this Feb 21, 2020
@rolljee
Copy link
Member

rolljee commented Feb 24, 2020

After CI is fixed

@Aschen
Copy link
Contributor

Aschen commented Feb 26, 2020

This will not fix the issue because as far I can see, we will still have problem with the dead link check.

The CI will never pass because those links are not in the same format as the others (/sdk/js/7 or /core/2) and so the program can not check if they really exists.

Why Vuepress is adding /sdk/js/7 at the beginning of links in those getting started?

@berthieresteban
Copy link
Contributor Author

This pr fix the links in the getting started.
I agree that we still have a problem with the deadlinks check in the CI...
I don't know why Vuepress is adding /sdk/js/7 only in the getting started links.
Also Vuepress add this base_url only if the link start with a /sdk/js/7 wich will become /sdk/js/7/sdk/js/7.
I havn't seen any modification on the doc repository wich could explain that...

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #492 into 7-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #492   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          32       32           
  Lines        1312     1312           
=======================================
  Hits         1254     1254           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea8c93...5395301. Read the comment docs.

@berthieresteban
Copy link
Contributor Author

Links are fixed, and deadlinks checks are passing.
I locally verified the links and they're good.
On Netlify, the links aren't working because the base_url wich is equal to / on Netlify instead of /sdk/js/7 normally.
For example: /sdk/js/7/controllers/index/create is a good link for localhost/docs.kuzzle.io but not good for preview netlify because it should be /controllers/index/create.

In short, links are good but leads to 404 on Netlify.

@Aschen Aschen changed the base branch from 7-dev to master February 27, 2020 05:19
@Aschen Aschen merged commit 3d1e7c0 into master Feb 27, 2020
@Aschen Aschen deleted the fix-getting-started-links branch February 27, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants