-
Notifications
You must be signed in to change notification settings - Fork 17
Fix getting started links #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After CI is fixed |
|
This will not fix the issue because as far I can see, we will still have problem with the dead link check. The CI will never pass because those links are not in the same format as the others ( Why Vuepress is adding |
|
This pr fix the links in the getting started. |
Codecov Report
@@ Coverage Diff @@
## 7-dev #492 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 32 32
Lines 1312 1312
=======================================
Hits 1254 1254
Misses 58 58Continue to review full report at Codecov.
|
|
Links are fixed, and deadlinks checks are passing. In short, links are good but leads to 404 on Netlify. |
What does this PR do?
Fix links for getting started react, react native, vuejs for sdk JS 7.
Les liens vers
/core/2ne seront pas accessible depuis le build netlify qui ne charge que les pages de doc du sdklLe test concernant les deadlink est pété d'ou le fail
(ex: src/controllers/auth/login in src/sdk/js/7//getting-started/react-native/index.md)
ce lien fonctionne sur netlify
How should this be manually tested?
Netlify
Other changes
/
Boyscout
Remove link to react kuzzle boilerplate in getting started react because it is not up to date with kuzzle versions