Allow to use custom controller in another package #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consider the following situation:
I have a custom controller in the package
custom-controller
:kuzzle-sdk
as peer dependenciesBaseController
class ofkuzzle-sdk
I have my project including
custom-controller
andkuzzle-sdk
as dependencies.I will not be able to use my controller since the SDK checks if the controller is an instanceof
BaseController
but since these class are used in 2 different modules, the check fail.This PR does not checks anymore if the controller is an instance of
BaseController
but it stills checks that the interface is respected (kuzzle
andname
properties present)Other changes