Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Mar 31, 2020

What does this PR do?

Consider the following situation:

I have a custom controller in the package custom-controller:

  • this package include kuzzle-sdk as peer dependencies
  • this package expose a controller inheriting from BaseController class of kuzzle-sdk

I have my project including custom-controller and kuzzle-sdk as dependencies.

I will not be able to use my controller since the SDK checks if the controller is an instanceof BaseController but since these class are used in 2 different modules, the check fail.

This PR does not checks anymore if the controller is an instance of BaseController but it stills checks that the interface is respected (kuzzle and name properties present)

Other changes

  • use scroll of 10s

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #500 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   95.80%   95.79%   -0.01%     
==========================================
  Files          32       32              
  Lines        1311     1308       -3     
==========================================
- Hits         1256     1253       -3     
  Misses         55       55              
Impacted Files Coverage Δ
src/Kuzzle.js 93.96% <ø> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7ee47...b58e059. Read the comment docs.

@Aschen Aschen merged commit de07e2d into master Mar 31, 2020
@rolljee rolljee deleted the fix-base-controller branch August 29, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants