Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Apr 6, 2020

What does this PR do?

Pagination in collection:list is useless and it's deprecated from Kuzzle.

This PR is meant to ensure that users will always get all possible collections from Kuzzle, even if they use an old version.

@Aschen Aschen self-assigned this Apr 6, 2020
@Aschen Aschen changed the base branch from master to 7-dev April 6, 2020 12:21
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #502 into 7-dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #502   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          32       32           
  Lines        1308     1308           
=======================================
  Hits         1253     1253           
  Misses         55       55           
Impacted Files Coverage Δ
src/controllers/Collection.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09191ca...9ee01a9. Read the comment docs.

@rolljee rolljee merged commit e91b9c9 into 7-dev Apr 15, 2020
@rolljee rolljee deleted the fix-collection-list branch April 15, 2020 07:49
@scottinet scottinet mentioned this pull request Apr 15, 2020
scottinet added a commit that referenced this pull request Apr 16, 2020
# [7.1.4](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.1.4) (2020-04-15)


#### Enhancements

- [ [#502](#502) ] Remove pagination from collection list   ([Aschen](https://github.com/Aschen))
- [ [#505](#505) ] Lighter production dependencies   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants