Fix collection getMapping #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leodau
reviewed
Apr 21, 2020
Comment on lines
+22
to
+25
| doc/7/getting-started/.react/cypress/screenshots | ||
| doc/7/getting-started/.react/cypress/videos | ||
| doc/7/getting-started/.vuejs/cypress/screenshots | ||
| doc/7/getting-started/.vuejs/cypress/videos |
There was a problem hiding this comment.
So this .gitignore has to be updated every time a new version comes out?
Suggested change
| doc/7/getting-started/.react/cypress/screenshots | |
| doc/7/getting-started/.react/cypress/videos | |
| doc/7/getting-started/.vuejs/cypress/screenshots | |
| doc/7/getting-started/.vuejs/cypress/videos | |
| doc/*/getting-started/.react/cypress/screenshots | |
| doc/*/getting-started/.react/cypress/videos | |
| doc/*/getting-started/.vuejs/cypress/screenshots | |
| doc/*/getting-started/.vuejs/cypress/videos |
Leodau
approved these changes
Apr 21, 2020
rolljee
approved these changes
Apr 22, 2020
Codecov Report
@@ Coverage Diff @@
## 7-dev #507 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 32 32
Lines 1308 1309 +1
=======================================
+ Hits 1253 1254 +1
Misses 55 55
Continue to review full report at Codecov.
|
Merged
Aschen
added a commit
that referenced
this pull request
Apr 28, 2020
# [7.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.2.0) (2020-04-28) #### Bug fixes - [ [#508](#508) ] Fix SearchResult.next with sort/size ([Aschen](https://github.com/Aschen)) - [ [#512](#512) ] Fix token expired ([Aschen](https://github.com/Aschen)) - [ [#511](#511) ] Avoid to mutate user options ([Aschen](https://github.com/Aschen)) - [ [#507](#507) ] Fix collection getMapping ([Aschen](https://github.com/Aschen)) #### New features - [ [#510](#510) ] Add security:refresh ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#509](#509) ] Add the rate limit property to Profile objects ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to pass the option
includeKuzzleMetato collection:getMapping method