Skip to content

Conversation

Leodau
Copy link
Contributor

@Leodau Leodau commented Jun 22, 2020

What does this PR do?

Implements support for the newly added ms:mexecute

How should this be manually tested?

const actions = [
    { 'action': 'set', 'args': { '_id': 'list:a', 'body': { 'value': 1, 'ex': 100, 'nx': true } } },
    { 'action': 'get', 'args': { '_id': 'list:a' } },
    { 'action': 'del', 'args': { 'body': { 'keys': ['list:a'] } } }];

  // Should Print : "[ [ null, 'OK' ], [ null, '1' ], [ null, 1 ] ]"
  console.log(await kuzzle.ms.mexecute(actions));

Boyscout

  • Applied one-var esrule in the memoryStorage file.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #524 into 7-dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #524   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          32       32           
  Lines        1318     1318           
=======================================
  Hits         1260     1260           
  Misses         58       58           
Impacted Files Coverage Δ
src/controllers/MemoryStorage.js 96.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d154d...85644a6. Read the comment docs.

@Leodau Leodau added the 7-dev label Jun 22, 2020
@Leodau Leodau requested a review from Yoann-Abbes June 26, 2020 09:37
@scottinet scottinet merged commit d1e6823 into 7-dev Jun 29, 2020
@scottinet scottinet mentioned this pull request Jul 23, 2020
scottinet added a commit that referenced this pull request Jul 23, 2020
# [7.3.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.3.0) (2020-07-23)


#### Bug fixes

- [ [#532](#532) ] Encode URI parameters when using the HTTTP protocol   ([scottinet](https://github.com/scottinet))
- [ [#516](#516) ] Fix query string construction   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### New features

- [ [#526](#526) ] Add typescript definitions for Auth controller   ([Aschen](https://github.com/Aschen))
- [ [#524](#524) ] Support ms:mexecute   ([Leodau](https://github.com/Leodau))
- [ [#522](#522) ] Add bulk:deleteByQuery   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#519](#519) ] Add document:updateByQuery   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### Enhancements

- [ [#517](#517) ] Add collection:update and deprecate collection:updateMapping   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#514](#514) ] Able to execute document search as GET http method   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
---
@rolljee rolljee deleted the feature/ms-mexecute branch August 29, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants