-
Notifications
You must be signed in to change notification settings - Fork 17
Error stacktrace overhaul #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 7-dev #596 +/- ##
==========================================
- Coverage 95.57% 87.35% -8.22%
==========================================
Files 32 33 +1
Lines 1310 1479 +169
Branches 0 260 +260
==========================================
+ Hits 1252 1292 +40
- Misses 58 136 +78
- Partials 0 51 +51
Continue to review full report at Codecov.
|
// the SDK one | ||
if (apiError.stack) { | ||
this.stack = apiError.stack + '\n'; | ||
this.stack += ' |\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put just one |\n
.
# [7.5.3](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.5.3) (2021-01-29) #### Enhancements - [ [#596](#596) ] Error stacktrace overhaul ([Aschen](https://github.com/Aschen)) - [ [#595](#595) ] Allows to not send realtime notification on document controller ([Aschen](https://github.com/Aschen)) ---
What does this PR do?
Improve SDK stacktrace by highlighting the user code and displaying Kuzzle stacktrace as well.
How should this be manually tested?
If Kuzzle is running in
development
mode then we display both stacktrace:If Kuzzle is not running in
development
mode we display only SDK stacktrace:Other changes
Boyscout