Skip to content

Conversation

Yoann-Abbes
Copy link
Contributor

What does this PR do ?

Add bulk:updateByQuery and document:mUpsert api actions

@Yoann-Abbes Yoann-Abbes self-assigned this Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #633 (cf908b9) into 7-dev (f0beacc) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #633      +/-   ##
==========================================
- Coverage   86.15%   85.75%   -0.40%     
==========================================
  Files          34       34              
  Lines        1589     1601      +12     
  Branches      279      282       +3     
==========================================
+ Hits         1369     1373       +4     
- Misses        162      170       +8     
  Partials       58       58              
Impacted Files Coverage Δ
src/controllers/Bulk.ts 57.14% <0.00%> (-13.45%) ⬇️
src/controllers/Document.ts 65.62% <0.00%> (-2.86%) ⬇️
src/protocols/WebSocket.ts 80.50% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0beacc...cf908b9. Read the comment docs.

Copy link
Contributor

@Shiranuit Shiranuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just apply the requested changes and this will be good for me 👍

@Yoann-Abbes Yoann-Abbes requested a review from scottinet May 4, 2021 14:24
Copy link
Contributor

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you should add the timeout option from @Shiranuit PR

|---------------|-------------------|-------------------------------------------|
| `index` | <pre>string</pre> | Index name |
| `collection` | <pre>string</pre> | Collection name |
| `searchQuery` | <pre>object</pre> | Query to match |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should match the method parameter name query

@Yoann-Abbes Yoann-Abbes requested a review from Aschen May 26, 2021 13:09
@Aschen Aschen merged commit a0f8051 into 7-dev May 31, 2021
@Aschen Aschen deleted the add-api-actions branch May 31, 2021 09:51
@Aschen Aschen mentioned this pull request May 31, 2021
Aschen added a commit that referenced this pull request May 31, 2021
# [7.7.1](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.7.1) (2021-05-31)


#### Enhancements

- [ [#633](#633) ] Add bulk:updateByQuery and document:mUpsert   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement API action bulk:updateByQuery Implement API action document:mUpsert

5 participants