Skip to content

Conversation

Shiranuit
Copy link
Contributor

@Shiranuit Shiranuit commented Aug 6, 2021

7.7.3 (2021-08-06)

Enhancements

Bug fixes

  • [ #653 ] Fix SDK emitting reconnect event twice caused by closing Websocket (Shiranuit)
  • [ #653 ] Fix SDK emitting disconnect event at each reconnection attempt that failed (Shiranuit)

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #656 (99b144d) into master (8c7b354) will decrease coverage by 0.50%.
The diff coverage is 64.00%.

❗ Current head 99b144d differs from pull request most recent head 98ef492. Consider uploading reports for the commit 98ef492 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   86.16%   85.65%   -0.51%     
==========================================
  Files          36       36              
  Lines        1662     1708      +46     
  Branches      302      309       +7     
==========================================
+ Hits         1432     1463      +31     
- Misses        173      183      +10     
- Partials       57       62       +5     
Impacted Files Coverage Δ
src/controllers/Realtime.ts 87.87% <33.33%> (-2.60%) ⬇️
src/protocols/WebSocket.ts 75.93% <36.00%> (-2.64%) ⬇️
src/Kuzzle.ts 85.58% <78.04%> (-1.46%) ⬇️
src/controllers/Auth.ts 78.35% <100.00%> (+1.75%) ⬆️
src/protocols/abstract/Realtime.ts 97.29% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7b354...98ef492. Read the comment docs.

@Shiranuit Shiranuit merged commit 1f04b94 into master Aug 6, 2021
@Shiranuit Shiranuit deleted the 7.7.3-proposal branch August 6, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant