Skip to content

Conversation

Shiranuit
Copy link
Contributor

What does this PR do ?

Add an helper that adds safer methods to obtain the window scope and to check if we are running inside of a browser.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #720 (e0c8655) into 7-dev (e814df2) will decrease coverage by 0.08%.
The diff coverage is 75.00%.

❗ Current head e0c8655 differs from pull request most recent head c2ad8ca. Consider uploading reports for the commit c2ad8ca to get more accurate results

@@            Coverage Diff             @@
##            7-dev     #720      +/-   ##
==========================================
- Coverage   83.21%   83.13%   -0.08%     
==========================================
  Files          45       46       +1     
  Lines        2091     2111      +20     
  Branches      399      406       +7     
==========================================
+ Hits         1740     1755      +15     
- Misses        273      277       +4     
- Partials       78       79       +1     
Impacted Files Coverage Δ
src/utils/debug.js 56.25% <50.00%> (-0.90%) ⬇️
src/utils/browser.ts 75.00% <75.00%> (ø)
src/protocols/abstract/Realtime.ts 97.56% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shiranuit Shiranuit merged commit e8df20f into 7-dev Jan 18, 2023
@Shiranuit Shiranuit mentioned this pull request Jan 18, 2023
@Shiranuit Shiranuit deleted the window-object-i-hate-you branch January 18, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants