Skip to content

fixes issue #82 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 30, 2016
Merged

fixes issue #82 #85

merged 8 commits into from
May 30, 2016

Conversation

scottinet
Copy link
Contributor

Solves multiple inconsistencies across all updateXXX and deleteXXX SDK methods:

  • KuzzleDataCollection.deleteDocument now return nothing, stopping the call chain
  • KuzzleDocument.delete now return the deleted document ID, instead of itself
  • KuzzleSecurity.updateRole now return an updated KuzzleRole object
  • KuzzleSecurity.updateProfile now return an updated KuzzleProfile object

@benoitvidis
Copy link
Contributor

+1

@xbill82
Copy link
Contributor

xbill82 commented May 30, 2016

👍 great PR

@scottinet scottinet merged commit 0cf0d8c into develop May 30, 2016
@scottinet scottinet deleted the fix-rc-83-update-and-delete-consistency branch May 30, 2016 09:01
@stafyniaksacha stafyniaksacha mentioned this pull request Jul 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottinet @benoitvidis @xbill82 @jenow