KUZ-480 Added method isActionAllowed to security #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {string} action - The action to perform. | ||
| * @param {string} index - (optional) The name of index to perform the action onto. | ||
| * @param {string} collection - (optional) The name of the collection to perform the action onto. | ||
| */ |
There was a problem hiding this comment.
nitpicking: missing @returns jsdoc
|
+1 |
|
Hmmm... I'm wondering whether it wouldn't be better to move the tests into |
|
No I think your initial approach is the right one: the |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the guidelines in https://confluence.kaliop.net/display/LABS/2016-05-24+-+Client-side+Policies
Just dropped in @ballinette's code snippet and all the tests are green :)
Please let me know if you estimate the tests are exhaustive: I surely forgot some edge cases.
Question: is the filename
methods.test.jsok? I was wondering if I should put it into theuserMethods.test.js.