Skip to content

Add KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME to customize imagePullSecrets #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME to customize imagePullSecrets #62

merged 2 commits into from
Nov 25, 2024

Conversation

huandu
Copy link
Contributor

@huandu huandu commented Jun 25, 2024

Add a new KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME environment variable to customize imagePullSecrets.

For instance, if KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME is set to my-secret, imagePullSecrets in Pod spec will be "imagePullSecrets": [ { "name": "my-secret" } ].

@huandu huandu changed the title Add KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME to enable imagePullSecrets Add KUBECTL_NODE_SHELL_IMAGE_PULL_SECRET_NAME to customize imagePullSecrets Jun 25, 2024
kvaps
kvaps approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kvaps kvaps merged commit 4884f4b into kvaps:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvaps kvaps kvaps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huandu @kvaps