combine multiple lg_feature markers instead of considering only closest one #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction_modifyitems have_feature is set a few lines below without consideration of its previous value, so drop this statement. Signed-off-by: Bastian Krause <[email protected]>
…erwriting previous ones
pytest allows setting markers via function decorators [1], class
decorators [2] and "pytestmark" global to mark whole modules [2].
Additionally, each of these variants can specify multiple markers.
labgrid's pytest plugin considered only the closest marker. Change that
to allow combinations of multiple markers.
This allows use cases like:
import pytest
pytestmark = pytest.mark.lg_feature("watchdog")
@pytest.mark.lg_feature("barebox")
def test_watchdog_barebox(barebox):
..
Tests in this module are only run if the feature flag "watchdog" is
available. The specific test "test_watchdog_barebox" is only run if the
feature flag "barebox" is available additionally.
[1] https://docs.pytest.org/en/latest/example/markers.html#adding-a-custom-marker-from-a-plugin
[2] https://docs.pytest.org/en/latest/example/markers.html#marking-whole-classes-or-modules
Signed-off-by: Bastian Krause <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
========================================
- Coverage 56.9% 56.9% -0.1%
========================================
Files 145 145
Lines 10861 10859 -2
========================================
- Hits 6182 6180 -2
Misses 4679 4679
Continue to review full report at Codecov.
|
Emantor
approved these changes
Oct 30, 2021
jluebbe
approved these changes
Nov 1, 2021
Bastian-Krause
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pytest allows setting markers via function decorators [1], class decorators [2] and "pytestmark" global to mark whole modules [2]. Additionally, each of these variants can specify multiple markers.
labgrid's pytest plugin considered only the closest marker. Change that to allow combinations of multiple markers.
This allows use cases like:
Tests in this module are only run if the feature flag "watchdog" is available. The specific test "test_watchdog_barebox" is only run if the feature flag "barebox" is available additionally.
[1] https://docs.pytest.org/en/latest/example/markers.html#adding-a-custom-marker-from-a-plugin
[2] https://docs.pytest.org/en/latest/example/markers.html#marking-whole-classes-or-modules
Checklist