real support of laravel 5.6 #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
|
Hey @wanghanlin Are you able to update your PR to add support for laravel 5.5+ and 6.0? Thanks! |
Closed
|
@atymic i think there is no active maintainer, this PR is already 1.5 year without someone merging, if you need it working i think it's better make a fork for yourself :) |
|
I've come on board to help maintain the notification channels, so I can merge the PR if you are still willing to work on it. |
|
Thanks! But I kind of forget why I updated this and everything might changed a lot here on both pusher side and laravel side, I don't think I have the time for this, so sorry for that. |
|
No worries, all good! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.