Skip to content

Conversation

kr3l
Copy link

@kr3l kr3l commented Nov 30, 2020

The string returned from si.system().model changed to e.g. 'Raspberry Pi 4 Model B Rev 1.2'. Changed the check to use processor and type info which is now also returned.

Verified on Raspberry Pi 4 Model B Rev 1.2

the returned information from si.system().model changed to e.g. 'Raspberry Pi 4 Model B Rev 1.2'. Changed the check to use processor and type info which is now returned.

Verified on Raspberry Pi 4 Model B Rev 1.2
@gregnr
Copy link
Contributor

gregnr commented Dec 13, 2020

Thanks for the great work on this PR @kr3l and sorry for the delay. Your implementation appears much more robust than it was before.

With that said we have decided to remove the Pi model check altogether, since so far every model appears to use the same JPEG signature. This also makes the library less brittle to changes that are outside of our control.

More details can be found here: #23 (comment)

This change is available now on v0.3.4.

@gregnr gregnr closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants