update getJpegSignature to work with current systeminformation #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the returned information from si.system().model changed to e.g. 'Raspberry Pi 4 Model B Rev 1.2'. Changed the check to use processor and type info which is now returned. Verified on Raspberry Pi 4 Model B Rev 1.2
|
Thanks for the great work on this PR @kr3l and sorry for the delay. Your implementation appears much more robust than it was before. With that said we have decided to remove the Pi model check altogether, since so far every model appears to use the same JPEG signature. This also makes the library less brittle to changes that are outside of our control. More details can be found here: #23 (comment) This change is available now on v0.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string returned from si.system().model changed to e.g. 'Raspberry Pi 4 Model B Rev 1.2'. Changed the check to use processor and type info which is now also returned.
Verified on Raspberry Pi 4 Model B Rev 1.2