Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Nov 14, 2025

Note

Flushes in-memory data to the persistent store on recovery with stale data, switches client evaluations to use the data system store, tightens polling selector handling, and adds thorough persistence tests.

  • Data system (FDv2):
    • Outage recovery: Add _persistent_store_outage_recovery to flush via Store.commit() when DataStoreStatus(available=True, stale=True); register listener; set status with DataStoreStatus(available, True) on availability.
    • Store.commit: Encode FEATURES/SEGMENTS via VersionedDataKind.encode before calling persistent init().
  • Client:
    • Use _data_system.store for evaluator sources, initialization checks, and all_flags_state() reads.
  • Polling:
    • Only send selector query param when selector.is_defined().
  • Protocol/typing:
    • Fix Synchronizer.sync return type to Generator["Update", None, None].
  • Tests:
    • Add tests for outage recovery flush behavior, commit encoding, commit without persistent store, and error handling in commit.

Written by Cursor Bugbot for commit 8e81cdb. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner November 14, 2025 16:35
[tool.poetry.group.dev.dependencies]
mock = ">=2.0.0"
pytest = ">=2.8"
pytest = "^8.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much larger a number.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but also we were always allowing it to float later. We are actually pinning it behind because it's breaking in older versions now.

@keelerm84 keelerm84 force-pushed the mk/sdk-1553/file-ds-fdv2 branch from 54cbdff to c0570e2 Compare November 18, 2025 16:24
Base automatically changed from mk/sdk-1553/file-ds-fdv2 to feat/fdv2 November 18, 2025 18:06
@keelerm84 keelerm84 force-pushed the mk/sdk-1574/outage-detector branch from 85f59ba to 8e81cdb Compare November 18, 2025 18:11
@keelerm84 keelerm84 merged commit b84c706 into feat/fdv2 Nov 18, 2025
32 of 35 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1574/outage-detector branch November 18, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants