Skip to content

Conversation

pyramation
Copy link
Collaborator

@pyramation pyramation commented Jun 30, 2025

Migrate all commented test cases to programmatic skip-tests.ts system

Summary

This PR systematically migrates all 162 commented test cases across kitchen-sink tests to the centralized skip-tests.ts file, replacing inline comment-based test skipping with a more maintainable programmatic approach.

Key Changes:

  • Added 162 new entries to test-utils/skip-tests.ts (bringing total to 185 entries)
  • Uncommented all test lines in 21 kitchen-sink test files across version ranges 13-14, 14-15, and 15-16
  • Preserved existing functionality - tests now skip programmatically via the existing test-utils/index.ts integration
  • Extracted version ranges and failure reasons from inline comments and structured them properly

Migration Coverage:

  • 13-14 version range: 124 test cases
  • 14-15 version range: 29 test cases
  • 15-16 version range: 9 test cases

Review & Testing Checklist for Human

  • Run full test suite across all version ranges (yarn test __tests__/kitchen-sink/13-14, yarn test __tests__/kitchen-sink/14-15, yarn test __tests__/kitchen-sink/15-16) to ensure no regressions
  • Verify programmatic skipping works by checking console output for "⏭️ SKIPPING:" messages during test runs
  • Spot-check skip-tests.ts entries for accuracy of version ranges and reasons (compare against original commented lines)
  • Confirm no commented tests were missed by searching for remaining "REMOVED:" comments in kitchen-sink files
  • Test a few specific failing cases manually to ensure they're properly skipped (e.g., latest/postgres/create_am-53.sql should skip in 13-14 range)

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "Kitchen Sink Tests"
        A["13-14/*.test.ts"]:::minor-edit
        B["14-15/*.test.ts"]:::minor-edit  
        C["15-16/*.test.ts"]:::minor-edit
    end
    
    subgraph "Test Infrastructure"
        D["test-utils/index.ts<br/>runFixtureTests()"]:::context
        E["test-utils/skip-tests.ts<br/>+162 entries"]:::major-edit
    end
    
    A --> D
    B --> D
    C --> D
    D --> E
    
    F["Commented Tests<br/>(// REMOVED: ...)"]:::context
    F -.-> E
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit
        L3["Context/No Edit"]:::context
    end

classDef major-edit fill:#90EE90
classDef minor-edit fill:#87CEEB  
classDef context fill:#FFFFFF
Loading

Notes

  • Migration approach: Used Python scripts to systematically extract commented test data and uncomment test lines
  • Verification: Confirmed 15-16 test suite passes (259/259 tests) with programmatic skipping active
  • Backward compatibility: Preserved all existing 18 skip-tests.ts entries
  • Common failure patterns: Most skipped tests fail due to parser syntax errors, AST transformation bugs, or Integer object differences

Session Info:

Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

- Added 162 test cases to skip-tests.ts with proper version ranges and reasons
- Uncommented all test lines in kitchen-sink files to restore normal execution
- Tests now use programmatic skipping via test-utils/index.ts integration
- Total skip-tests.ts entries: 185 (18 existing + 162 new)
- Covers version ranges: 13-14 (124 tests), 14-15 (29 tests), 15-16 (9 tests)

Migration details:
- Extracted all commented test cases with REMOVED reasons across 21 test files
- Preserved existing skip-tests.ts structure and 18 original entries
- Verified programmatic skipping works correctly with console skip messages
- All 15-16 tests pass (259/259) with new programmatic skipping system
- More maintainable approach than inline comments in test files

Co-Authored-By: Dan Lynch <[email protected]>
- Added missing comma after rangetypes-302.sql in test array
- Resolves CI failure: 'comma expected' TypeScript error at line 309
- Maintains proper array structure for programmatic test skipping

Co-Authored-By: Dan Lynch <[email protected]>
@pyramation pyramation force-pushed the transform/skip-tests-migration branch from 4762dae to 2cf8f01 Compare June 30, 2025 17:29
@pyramation pyramation merged commit 3ce9c95 into transform/base Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant