Skip to content

Conversation

@Ruben-VandeVelde
Copy link
Contributor

This seems to work and I think pinning everything should ensure that it keeps working, but note that pylock.toml is a very new feature, so I could also see an argument for holding out on adopting it.

@bryangingechen
Copy link
Contributor

Thanks! I've been hoping to upgrade python and other dependencies in this project for a while. I'm assuming the instructions in the README are still accurate? (Maybe we want to add a .python-version and while we're at it move fully to a uv-based setup, but that might be a discussion for another time.)

@Ruben-VandeVelde
Copy link
Contributor Author

Oh, I missed the readme. I guess the pip command there might give you different versions of the dependencies, but then I don't know if we want to recommend uv to casual users.


- name: install Python dependencies
run: python -m pip install -r requirements.txt
run: uv pip install --preview -r pylock.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything that will ensure requirements.txt and pylock.toml remain synchronized?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants