-
Notifications
You must be signed in to change notification settings - Fork 162
feat: documentation overview page #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lean4
Are you sure you want to change the base?
Conversation
|
This is great! A few things:
|
|
Thanks for the review! I implemented your suggestions: adding a show/hide button for the tag filters, tag counts (hiding tags with count 0), and also hiding entries with tag For author data, I went with a plain string field, comma-separated like we have for the Authors: line in the copyright headers. For entries that do not have any obvious authorship information and live on the leanprover-community.github.io website, I went with "the Mathlib community". Or should we be more precise (for example, looking at the commit history for this information)? |
|
Thanks, looks like you've addressed all my concerns! Am I correct that there's intentionally no way to view items tagged I'm fine with "the Mathlib community"; it would feel strange to include authorship info that isn't written in the source files. (If any of the authors would like to claim authorship of one of the documents here, we'll have to remember to remind them to update both the markdown and this yaml file though) |
|
I love this, thanks! I just have one comment: would it be possible to have links external to Maybe this already happens, but I noticed that it didn't in the html file linked in the PR description. |
|
What about blogposts on the community website? For example, @Paul-Lez and I are publishing simproc documentation on it. Should the corresponding blogposts be referred in documentation.yaml, or is the consensus that we should perhaps turn the blogposts into a more perennial form of documentation? |
Doing so is mostly discouraged by web accessibility guidelines: https://www.w3.org/WAI/WCAG22/Techniques/general/G200 What we could do, however, is add a little icon to indicate external links. (It may be a good idea in general to indicate whether something is community-maintained or not!) |
Good question! Blog posts can definitely count as documentation, and we already link a few blog posts on this page. But they should also remain relevant as time goes by. Are you, as authors, planning on updating your post to keep up with Lean changes? If not, making it part of the living set of documentation we have (maybe eventually as part of the Mathlib manual?) would be worth it. But I think for this PR we should focus more on the structure of the page, not its exact contents. I'd be very happy to accept PRs changing the contents of |
This page is intended to be a complete collection of all the pieces of documentation for Mathlib users and Lean users more generally. I have gone through everything findable on the community website, and quite a few suggestions on the Zulip chat and tagged and categorized them all.
On the rendered page, we can see a diagram of the Divio classification system. I also added the possibility to filter the entries by tags.
Here is the rendered page, which works standalone in your browser (only missing a bit of its formatting):
documentation.html.