-
Notifications
You must be signed in to change notification settings - Fork 889
[Merged by Bors] - feat(Algebra/Star/NonUnitalSubsemiring): Add NonUnitalStarSubsemiring #12938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
j-loreaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want StarSubset, unless you have an explicit application in mind. Also, it would be nice if the unital versions of all these were placed in a separate file.
|
no need to include me in the copyright. |
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…unity/mathlib4 into mans0954/StarSubSemiring
Import summaryNo significant changes to the import graph |
PR summary f3295abb61Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
j-loreaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
|
✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Jireh Loreaux <[email protected]>
…unity/mathlib4 into mans0954/StarSubSemiring
|
bors r+ |
…#12938) Definitions and basic properties of non-unital star subsemirings Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
…#12938) Definitions and basic properties of non-unital star subsemirings Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
Definitions and basic properties of non-unital star subsemirings
This file heavily copies
Mathlib.Algebra.Star.NonUnitalSubalgebra, so I'm happy to assign the copyright to @j-loreaux if that's the appropriate thing to do.So far I've mostly only developed what's required for #6595 - I thought I'd check that this was the right approach before going further.