forked from NVIDIA/TensorRT-LLM
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
[None][feat] add gatherKvPageOffsetsKernel #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            lfr-0531
  merged 3 commits into
  feat/sparse_attention
from
user/fanrongl/add_trtllm_sparse_gen_support
  
      
      
   
  Aug 25, 2025 
      
    
                
     Merged
            
            [None][feat] add gatherKvPageOffsetsKernel #32
                    lfr-0531
  merged 3 commits into
  feat/sparse_attention
from
user/fanrongl/add_trtllm_sparse_gen_support
  
      
      
   
  Aug 25, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Fanrong Li <[email protected]>
Signed-off-by: Fanrong Li <[email protected]>
Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      pushed a commit
      that referenced
      this pull request
    
      Sep 5, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      pushed a commit
      that referenced
      this pull request
    
      Sep 19, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      pushed a commit
      that referenced
      this pull request
    
      Sep 26, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      pushed a commit
      that referenced
      this pull request
    
      Sep 30, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  lfr-0531 
      added a commit
      that referenced
      this pull request
    
      Oct 5, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  lfr-0531 
      added a commit
      that referenced
      this pull request
    
      Oct 5, 2025 
    
    
      
  
    
      
    
  
* add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      added a commit
      that referenced
      this pull request
    
      Oct 8, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      added a commit
      that referenced
      this pull request
    
      Oct 9, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      added a commit
      that referenced
      this pull request
    
      Oct 10, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  lfr-0531 
      pushed a commit
      that referenced
      this pull request
    
      Oct 13, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      added a commit
      that referenced
      this pull request
    
      Oct 13, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  heyuhhh 
      added a commit
      that referenced
      this pull request
    
      Oct 13, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
    
  lfr-0531 
      pushed a commit
      that referenced
      this pull request
    
      Oct 13, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yuhangh <[email protected]> Update sparse attention parameters passing logic Signed-off-by: yuhangh <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] add gatherKvPageOffsetsKernel (#32) * add gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Add sparse kv indices write kernel & fix several bugs Signed-off-by: yuhangh <[email protected]> fix for rebase Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] integrate block sparse attention kernels (#33) * integrate block sparse attention kernels. Signed-off-by: Fanrong Li <[email protected]> * fix. Signed-off-by: Fanrong Li <[email protected]> * Support num_kv_heads in seq_len & fix several workspace size bugs Signed-off-by: yuhangh <[email protected]> * update block sparse attention kernel to support per-head kv_len. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * update kernel meta info. * add more block sparse kernels. * disable rope_fusion for sparse attention. Signed-off-by: Fanrong Li <[email protected]> * fix block sparse attention kernels. * update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> * fix workspace issue. Signed-off-by: Fanrong Li <[email protected]> * minor fix Signed-off-by: yuhangh <[email protected]> * fix gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * remove cuda stream sync. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] change the sparse indices format and update the gatherKvPageOffsetsKe… (#34) * change the sparse indices format and update the gatherKvPageOffsetsKernel. Signed-off-by: Fanrong Li <[email protected]> * update kv write & optimize logic of using tllmgen kernels Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> Signed-off-by: yuhangh <[email protected]> Co-authored-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> add paged kt cache (1st commit). Signed-off-by: Fanrong Li <[email protected]> minnor fix. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for vanilla RocketKV. Signed-off-by: Fanrong Li <[email protected]> add paged kt cache to rocketkv trtllm. Signed-off-by: Fanrong Li <[email protected]> fix _single_request_update_kt_cache for trtllm RocketKV. Signed-off-by: Fanrong Li <[email protected]> fix k_snap length. Signed-off-by: Fanrong Li <[email protected]> fix memory issue when using paged kt cache. Signed-off-by: Fanrong Li <[email protected]> fix rebase breaks Signed-off-by: yuhangh <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> fix rebase bug. Signed-off-by: Fanrong Li <[email protected]> update block sparse attention kernel. Signed-off-by: Fanrong Li <[email protected]> fix params issue Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Do sparse attention functional clean (#43) * fix several bugs & adjust some code Signed-off-by: yuhangh <[email protected]> * minor code clean Signed-off-by: yuhangh <[email protected]> * Add simple unittest for rocketkv Signed-off-by: yuhangh <[email protected]> * Adjustment for sparse attention params and example Signed-off-by: yuhangh <[email protected]> * fix bugs introduced by last commit Signed-off-by: yuhangh <[email protected]> * Optimize Xqa_params and num_sparse_kv_tokens Signed-off-by: yuhangh <[email protected]> * Fix gather kernel & minor adjustment Signed-off-by: yuhangh <[email protected]> * Rename sparse_attention_params in xqa_params Signed-off-by: yuhangh <[email protected]> * minor Signed-off-by: yuhangh <[email protected]> --------- Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][feat] Update trtllm-gen fmha kernels and remove block sparse cubins (#44) * rm sparse kernels. Signed-off-by: Fanrong Li <[email protected]> * update new kernel. Signed-off-by: Fanrong Li <[email protected]> * update trtllm-gen fmha. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rebase conflicts Signed-off-by: yuhangh <[email protected]> minor fix Signed-off-by: yuhangh <[email protected]> pre-commit fix Signed-off-by: yuhangh <[email protected]> Signed-off-by: Fanrong Li <[email protected]> [None][fix] update trtllm sparse attention interface (#45) * update trtllm sparse attention interface. Signed-off-by: Fanrong Li <[email protected]> * fix interface. Signed-off-by: Fanrong Li <[email protected]> --------- Signed-off-by: Fanrong Li <[email protected]> fix rocketkv interface. (#47) Signed-off-by: Fanrong Li <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
@coderabbitai summary
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.