Fully Implemented ABI-Parsing #40

DinoKengi · 2025-09-23T01:46:31Z

This section should be able to ABI-Parse binary files that are fed.
Note: Is currently being fed a file, will need to connect ELF parser in the future.
Another note: rebasing last time made an oopsies so anything after the 'fixed abi parsing' commits shouldn't have happened.

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard move headers and section data to be stored in unordered_maps and vectors Added Doxygen documentation and reorganized folders fix formatting to match libhal styling guide

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard move headers and section data to be stored in unordered_maps and vectors Added Doxygen documentation and reorganized folders fix formatting to match libhal styling guide

* Created POC GCC IPA callgraph parser Script is designed for testing and workshopping. Script is written in python and documented on how it works * 👷 Added debugging settings and defaulted to Debug builds * ❇️ Started to port the parsing code for gcc No API yet

PhazonicRidley · 2025-10-16T02:33:27Z

Resolve your conflicts and rebase with CI

kammce

It might be a good idea to pick a style for naming across the code base. But you can leave that for later.

ls.cpp.save

src/main_asm

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard move headers and section data to be stored in unordered_maps and vectors Added Doxygen documentation and reorganized folders fix formatting to match libhal styling guide

* Created POC GCC IPA callgraph parser Script is designed for testing and workshopping. Script is written in python and documented on how it works * 👷 Added debugging settings and defaulted to Debug builds * ❇️ Started to port the parsing code for gcc No API yet

* fixed missing directory * 💚 Created basic CI Only works on linux currently TODO: Add windows and mac pipelines TODO: Add lint checks TODO: Add deployment --------- Co-authored-by: Mchan2003 <[email protected]>

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

…, move loading of the headers to the constructor, reformat to fit libhal formatting standard move headers and section data to be stored in unordered_maps and vectors Added Doxygen documentation and reorganized folders fix formatting to match libhal styling guide

* Created POC GCC IPA callgraph parser Script is designed for testing and workshopping. Script is written in python and documented on how it works * 👷 Added debugging settings and defaulted to Debug builds * ❇️ Started to port the parsing code for gcc No API yet

PhazonicRidley

Looks good so far. Please make a unit test with your current logic in your main.cpp.

PhazonicRidley · 2025-11-10T09:43:49Z

src/main.cpp

-    std::ignore = argv;
-    std::println("Hello C++: {}", __cplusplus);
+    // temporarily reading LSDA file before merging with main
+    const char* path = (argc >= 2 ? argv[1] : "LSDA/lsda");


This is a test, should be done in a unit test program. We want to use Michael's main

PhazonicRidley · 2025-11-10T09:44:28Z

LSDA/lsda

Assuming this is for a test, move to testing folders and out of root, same goes for the other files in this folder

PhazonicRidley · 2025-11-10T09:45:37Z

include/abi_parse.hpp

+    int64_t next;              // next action in list
+};
+
+class Abi_parser 


Nit: Seems like we're going with PascalCase for our classes

PhazonicRidley · 2025-11-10T09:47:15Z

include/abi_parse.hpp

+private:
+    void check(size_t n) const; // checks that n bytes remains in LSDA buffer before read 
+
+    const std::vector<uint8_t>& data;  // raw LSDA byte data


Is there a reason the ABI parser class doesn't own the raw data?

I'll chime in and say that you should not store references within the fields of a C++ class. This class should own the vector that owns the data. This is asking for pointer invalidation.

PhazonicRidley · 2025-11-10T09:49:13Z

src/abi_parse.cpp

+    while (i < buf.size()) {
+        uint8_t byte = buf[i++];
+        result |= static_cast<uint64_t>(byte & 0x7F) << shift;
+        if ((byte & 0x80) == 0) break;


Nit: Personally, I prefer {} around any if/while/for clauses. nbd if you wanna keep it this way

PhazonicRidley · 2025-11-10T09:49:58Z

src/abi_parse.cpp

+    }
+
+    if (indirect) {
+    throw std::runtime_error("indirect doesn't support raw LSDA");


Fix formatting, just run clang format via vs code

PhazonicRidley · 2025-11-10T09:54:48Z

src/abi_parse.cpp

+    start_enc = read8();
+    if (start_enc != 0xFF) {
+        const uint64_t pcrel_base = static_cast<uint64_t>(index);
+        (void) r_encode(start_enc, pcrel_base); // reads and ignores


Use std::ignore instead of (void)

PhazonicRidley · 2025-11-10T09:59:29Z

src/abi_parse.cpp

+        Action a{};
+        a.type = read_sleb128(data, index);    
+        if (index > limit_end)
+            throw std::runtime_error("action parsing went over limit");


{} around single line if blocks, very easy to have an intent error and have the if block attach to things you dont want

kammce

I'm not sure what this parser provides to the code base. Does it just parse the entire exception data table? If so, how is this associated with the functions it belongs to? Also, the expanded data of the call site and action table isn't what we need, its the association between scopes and caught types which does not exist in this commit. But thats fine if that'll be done in a future PR.

kammce · 2025-11-10T18:47:56Z

include/abi_parse.hpp

+private:
+    void check(size_t n) const; // checks that n bytes remains in LSDA buffer before read 
+
+    const std::vector<uint8_t>& data;  // raw LSDA byte data


I'll chime in and say that you should not store references within the fields of a C++ class. This class should own the vector that owns the data. This is asking for pointer invalidation.

kammce · 2025-11-10T18:49:44Z

src/abi_parse.cpp

+    for (int i = 0; i < 2; ++i)
+        v |= static_cast<uint16_t>(data[index++]) << (i * 8);


I highly recommend using curly braces for all blocks.

kammce · 2025-11-10T18:55:01Z

include/abi_parse.hpp

+    int64_t next;              // next action in list
+};
+
+class Abi_parser 


Name of the this class is very vague. Rename this to something like gcc_lsda_parser.

kammce · 2025-11-10T18:55:36Z

include/abi_parse.hpp

+    uint64_t start;        // start of protected range
+    uint64_t length;       // length of protected range
+    uint64_t landing_pad;  // landing pad address
+    int64_t action;            // throw to action table


Suggested change

int64_t action; // throw to action table

int64_t action; // offset into action table

kammce · 2025-11-10T18:58:10Z

include/abi_parse.hpp

+struct Action 
+{
+    int64_t type;              // index type
+    int64_t next;              // next action in list
+};


Although this is whats within the action table, it makes more sense to associate the call site with the ordered list of types caught by that scope. Then you can use that to compare thrown type against caught type.

kammce · 2025-11-10T18:58:54Z

include/abi_parse.hpp

+{
+public:
+    explicit Abi_parser(const std::vector<uint8_t>& lsda_data);
+    void parse();


Why not parse at construction? Why do we need another API for starting the parse?

DinoKengi and others added 19 commits April 17, 2025 10:37

added abiparse.hpp and .cpp to parse through dummy

b0135b5

Fixed some issues within CMakeLists and main

ac259e6

Added more concentrated dummy LSDA to test parsing

ce28d69

fixed abi parsing to properly parse action table

d031e92

add elf_parser .hpp with function to open the elf file and read out t…

48c111b

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

added exception error handling and removed personal test folder

ddadfa8

👷 Added debugging settings and defaulted to Debug builds

048c289

✨ testing: Created framework for unit testing

3436f6e

add elf_parser .hpp with function to open the elf file and read out t…

fa30090

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

fixed conan file and build

f8406ae

✨ testing: Created framework for unit testing

caf51c1

fix conan line duplicate

d2c41f8

deleted unneeded files from repo

58f4d82

added abiparse.hpp and .cpp to parse through dummy

bdf49d8

Fixed some issues within CMakeLists and main

fc81050

keeping main after changes

0d742db

PhazonicRidley self-requested a review October 26, 2025 01:02

Merge branch 'main' into ABI-Parsing

4471e15

kammce reviewed Oct 26, 2025

View reviewed changes

ls.cpp.save Outdated Show resolved Hide resolved

src/main_asm Outdated Show resolved Hide resolved

Mchan2003 and others added 7 commits November 3, 2025 10:54

add elf_parser .hpp with function to open the elf file and read out t…

dbdcd53

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

✨ testing: Created framework for unit testing

c030f0a

✨ testing: Created framework for unit testing

3daa2fa

fixed missing directory

9dcea8d

🚑 Fixed CMake configuration

9b7551a

PhazonicRidley and others added 12 commits November 3, 2025 10:55

💚 Made basic CI (#42)

e27f461

* fixed missing directory * 💚 Created basic CI Only works on linux currently TODO: Add windows and mac pipelines TODO: Add lint checks TODO: Add deployment --------- Co-authored-by: Mchan2003 <[email protected]>

added abiparse.hpp and .cpp to parse through dummy

8f12075

Fixed some issues within CMakeLists and main

eba1217

fixed abi parsing to properly parse action table

e5a5947

add elf_parser .hpp with function to open the elf file and read out t…

a3baf1c

…he elf header Completed Section and Program header parsing implement function to store lsda into a binary file and another to close the elf file fixed formatting fixed syntax errors

✨ testing: Created framework for unit testing

d0d7beb

added abiparse.hpp and .cpp to parse through dummy

9f68f9f

Removing files and fixing branch

b3f19ef

small fixes

617de8a

CMake changes

b38cfb5

PhazonicRidley requested changes Nov 10, 2025

View reviewed changes

PhazonicRidley requested a review from kammce November 10, 2025 10:02

kammce requested changes Nov 10, 2025

View reviewed changes

		for (int i = 0; i < 2; ++i)
		v \|= static_cast<uint16_t>(data[index++]) << (i * 8);

	int64_t action; // throw to action table
	int64_t action; // offset into action table

Fully Implemented ABI-Parsing #40

Are you sure you want to change the base?

Fully Implemented ABI-Parsing #40

Uh oh!

Conversation

DinoKengi commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhazonicRidley commented Oct 16, 2025

Uh oh!

kammce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PhazonicRidley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kammce left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DinoKengi commented Sep 23, 2025 •

edited

Loading