Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Conversation

@vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 7, 2020

In the context of deprecating peer-info as described on libp2p/js-libp2p#589, this PR removes the peer-info usage on pubsub internal peer data structure. Moreover, this uses the new topology API, which also uses peer-id instead of peer-info

BREAKING CHANGE: using new topology api with peer-id instead of peer-info and new pubsub internal peer data structure

Needs:

BREAKING CHANGE: using new topology api with peer-id instead of peer-info and new pubsub internal peer data structure
@vasco-santos vasco-santos force-pushed the chore/remove-peer-info-usage branch from badc440 to 3a5b3a9 Compare April 22, 2020 14:28
@vasco-santos vasco-santos requested a review from jacobheun April 22, 2020 14:33
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vasco-santos vasco-santos merged commit cb3497c into master Apr 23, 2020
@vasco-santos vasco-santos deleted the chore/remove-peer-info-usage branch April 23, 2020 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants