Recommend proto3 #506
Merged
Recommend proto3 #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
marten-seemann
approved these changes
Jan 21, 2023
mxinden
approved these changes
Jan 23, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the follow-up across the whole repository.
Member
|
I will update #497 once this is merged. |
mxinden
added a commit
that referenced
this pull request
Jan 24, 2023
See recommendation change with #506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the README to recommend proto3. Makes all existing protobuf without an explicit syntax have
syntax="proto2".See #465 for the discussion around this change.
Closes #465