Skip to content

chore: add fixmes #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
+7 −3
Merged

chore: add fixmes #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5164db5
chore: add fixmes
madlabman Sep 23, 2025
22c5ef5
fix: IPFS desc & fixme
Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/upgrade_tw_csm2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@
DSM_QUORUM_SIZE = 4

# ============================= Description ==================================
IPFS_DESCRIPTION = "Triggerable withdrawals and CSM v2 upgrade voting"
IPFS_DESCRIPTION = """
1. **Upgrade to CSM v2 and increase CSM stake share limit from 3% to 5%**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0xc3f92bcdf8926cfa7528ca6a979c0fdce1e4d0cfaaa72dd6410a76a2e1e55766). Items 1.34-1.59. Audit & deployment verification by: [Statemind](https://github.com/lidofinance/audits/blob/main/Statemind%20Triggerable%20Withdrawals%20and%20CSM%20v2%20Audit%20Report%2009-2025.pdf) | [Ackee](https://github.com/lidofinance/audits/blob/main/Ackee%20Blockchain%20Community%20Staking%20Module%20v2%20Audit%20Report%2009-2025.pdf).
2. **Activate Triggerable Withdrawals**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0x7d7f0e1a6d181310f8752af37e20515a9be258f30b211872f9acca99bc478851). Items 1.1-1.33, 1.60-1.66, 2-4. Audit & deployment verification by [Statemind](https://github.com/lidofinance/audits/blob/main/Statemind%20Triggerable%20Withdrawals%20and%20CSM%20v2%20Audit%20Report%2009-2025.pdf) | Audit by [Ackee](https://github.com/lidofinance/audits/blob/main/Ackee%20Blockchain%20Lido%20Triggerable%20Withdrawals%20Audit%20Report%2009-25.pdf).
3. **Update the reward address and name for Node Operator ID 25 `Nethermind`**, as per [Snapshot decision](https://snapshot.box/#/s:lido-snapshot.eth/proposal/0x3f68e9bc69850da419211c3d9f0a76d006ed044abc0f8bc845bc1d1cf3db0a8d). Items 1.67, 1.68.
4. **Rotate Deposit Security Committee address for `Kiln`**. [Requested on the forum](https://research.lido.fi/t/security-disclosure-kiln-precautionary-out-of-order-exits-in-response-security-incident/10654/3). Items 1.69, 1.70."""


def encode_staking_router_proxy_update(implementation: str) -> Tuple[str, str]:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_tw_csm2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,12 @@ def check_proxy_implementation(proxy_address, expected_impl):

EASYTRACK_CS_SET_VETTED_GATE_TREE_FACTORY = "0xBc5642bDD6F2a54b01A75605aAe9143525D97308"

EXPECTED_VOTE_ID = None
EXPECTED_VOTE_ID = 192
EXPECTED_DG_PROPOSAL_ID = 5
EXPECTED_VOTE_EVENTS_COUNT = 4
EXPECTED_DG_EVENTS_FROM_AGENT = 69
EXPECTED_DG_EVENTS_COUNT = 71
IPFS_DESCRIPTION_HASH = "bafkreih5app23xbevhswk56r6d2cjdqui5tckki6szo7loi7xe25bfgol4"
IPFS_DESCRIPTION_HASH = "bafkreicbufoefjutdeadrzhbqnxgonc5rljlwyyrftytxkykiufkpmc3ii"

NETHERMIND_NO_ID = 25
NETHERMIND_NO_NAME_OLD = "Nethermind"
Expand Down
Loading