Skip to content

Fix deposits tests #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
Merged

Fix deposits tests #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7406efe
Fix deposits tests
hweawer Oct 2, 2025
628c676
Increase coefficients
hweawer Oct 2, 2025
193004a
Remove +12
hweawer Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/regression/test_sdvt_rewards_happy_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ def test_rewards_distribution_happy_path(simple_dvt_module_id, cluster_participa

# fill the deposit buffer
deposits_count = 10
fill_deposit_buffer(deposits_count)

fill_deposit_buffer(deposits_count, heuristic=10000)
# deposit to simple dvt
module_summary_before = staking_router.getStakingModuleSummary(simple_dvt_module_id)
lido.deposit(deposits_count, simple_dvt_module_id, "0x", {"from": deposit_security_module})
Expand Down
1 change: 1 addition & 0 deletions tests/regression/test_staking_module_happy_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ def module_happy_path(staking_module, extra_data_service, impersonated_agent, st
assert first_no_summary_after["depositableValidatorsCount"] == 0
assert first_no_summary_after["targetLimitMode"] == 1

fill_deposit_buffer(50, heuristic=10000)
# Deposit
(
no1_deposited_keys_before,
Expand Down
4 changes: 2 additions & 2 deletions utils/test/deposits_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
WEI_TOLERANCE = 5 # wei tolerance to avoid rounding issue


def fill_deposit_buffer(deposits_count):
def fill_deposit_buffer(deposits_count, heuristic=1):
deposit_size = ETH(32)
depositable_eth = deposits_count * deposit_size
depositable_eth = deposits_count * deposit_size * heuristic

cover_wq_demand_and_submit(depositable_eth)

Expand Down
Loading