fix: Migrate from deprecated vector_dbs to vector_stores API #678
Conversation
WalkthroughReplaces vector DB listing with vector store listing in query endpoints; updates Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client as HTTP Client
participant Endpoint as query / streaming_query
participant SDK as API Client
participant RAG as get_rag_toolgroups
participant Agent as Toolgroup Agent
Client->>Endpoint: Request (query / streaming)
Endpoint->>SDK: client.vector_stores.list()
note right of SDK `#D6EAF8`: returns response object with `.data` list
SDK-->>Endpoint: list response (data -> vector_store objects)
Endpoint->>Endpoint: extract vector_store_ids from .data (ids)
Endpoint->>RAG: get_rag_toolgroups(vector_store_ids)
RAG-->>Endpoint: Toolgroups or None
Endpoint->>Agent: Build/run agent with toolgroups
Agent-->>Client: Response / stream
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧬 Code graph analysis (2)src/app/endpoints/streaming_query.py (1)
tests/unit/app/endpoints/test_query.py (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luis5tb
force-pushed
the
vector_stores
branch
2 times, most recently
from
93b4b1b to
a5f1f16
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/app/endpoints/query.py(2 hunks)src/app/endpoints/streaming_query.py(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/app/endpoints/streaming_query.py
🧰 Additional context used
📓 Path-based instructions (5)
src/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
Use absolute imports for internal modules (e.g., from auth import get_auth_dependency)
Files:
src/app/endpoints/query.py
src/app/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
Use standard FastAPI imports (from fastapi import APIRouter, HTTPException, Request, status, Depends) in FastAPI app code
Files:
src/app/endpoints/query.py
**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.py: All modules start with descriptive module-level docstrings explaining purpose
Use logger = logging.getLogger(name) for module logging after import logging
Define type aliases at module level for clarity
All functions require docstrings with brief descriptions
Provide complete type annotations for all function parameters and return types
Use typing_extensions.Self in model validators where appropriate
Use modern union syntax (str | int) and Optional[T] or T | None consistently
Function names use snake_case with descriptive, action-oriented prefixes (get_, validate_, check_)
Avoid in-place parameter modification; return new data structures instead of mutating arguments
Use appropriate logging levels: debug, info, warning, error with clear messages
All classes require descriptive docstrings explaining purpose
Class names use PascalCase with conventional suffixes (Configuration, Error/Exception, Resolver, Interface)
Abstract base classes should use abc.ABC and @AbstractMethod for interfaces
Provide complete type annotations for all class attributes
Follow Google Python docstring style for modules, classes, and functions, including Args, Returns, Raises, Attributes sections as needed
Files:
src/app/endpoints/query.py
src/{app/**/*.py,client.py}
📄 CodeRabbit inference engine (CLAUDE.md)
Use async def for I/O-bound operations and external API calls
Files:
src/app/endpoints/query.py
src/app/endpoints/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
In API endpoints, raise FastAPI HTTPException with appropriate status codes for error handling
Files:
src/app/endpoints/query.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e_tests (ci)
- GitHub Check: e2e_tests (azure)
🔇 Additional comments (2)
src/app/endpoints/query.py (2)
686-688: LGTM! API migration is correct.The migration from
client.vector_dbs.list()toclient.vector_stores.list()correctly implements the API update. The list comprehension properly extracts IDs from the response data.
689-689: LGTM! Function call updated correctly.The call to
get_rag_toolgroupsnow correctly passesvector_store_ids, maintaining consistency with the API migration.
luis5tb
force-pushed
the
vector_stores
branch
from
a5f1f16 to
7fd8a8f
Compare
luis5tb
force-pushed
the
vector_stores
branch
from
7fd8a8f to
8fb26da
Compare
luis5tb
force-pushed
the
vector_stores
branch
from
8fb26da to
ad70fef
Compare
1 participant
Description
This PR updates the codebase to use the new vector_stores API instead of the deprecated vector_dbs API, which was removed in llama-stack PR #3774.
Type of change
Related Tickets & Documents
Summary by CodeRabbit
Refactor
Tests