Consider setting `GUESTAGENT_COMPRESS=y` by default

[AkihiroSuda]

lima/Kconfig

Lines 34 to 38 in ddc0081

	config GUESTAGENT_COMPRESS
	bool "guestagent compress"
	help
	Compress lima-guestagent
	default n

• Allow compressing lima-guestagent with gzip #2438

This should be enabled by default unless there is a significant drawback?

[afbjorklund]

It should be a little slower* (due to legacy gzip), but not more than that.

* in the order of milliseconds, like a quarter of a second or something?

[kairveeehh]

would like to take up this issue , should I follow up with a PR or wait for assignment?

[AkihiroSuda]

You can open a PR at anytime without waiting for an assignment.

Things to consider:

• Confirm that the overhead isn't more than a few seconds on typical machines
• Print a warning when the both compressed agent and the uncompressed one are present. The one with the newer timestamp should be selected.

[kairveeehh]

You can open a PR at anytime without waiting for an assignment.

Things to consider:

• Confirm that the overhead isn't more than a few seconds on typical machines
• Print a warning when the both compressed agent and the uncompressed one are present. The one with the newer timestamp should be selected.

Working on it.

[AkihiroSuda]

@kairveeehh

Working on it.

Are you still working on this?

[kairveeehh]

@kairveeehh

Working on it.

Are you still working on this?

Yes , was a bit busy cause of uni exams but I'll continue to work on it.

[AkihiroSuda]

This issue will be fixable in a single-line PR, after finishing this refactoring:

• guestagent refactoring #3504

[AkihiroSuda]

@kairveeehh Do you want to open this PR?

diff --git a/Kconfig b/Kconfig
index d52d6fb0..7e40d787 100644
--- a/Kconfig
+++ b/Kconfig
@@ -47,4 +47,4 @@ config GUESTAGENT_COMPRESS
        bool "guestagent compress"
        help
                Compress lima-guestagent
-       default n
+       default y
diff --git a/config.mk b/config.mk
index 9a02aae2..06ab7787 100644
--- a/config.mk
+++ b/config.mk
@@ -5,4 +5,4 @@ CONFIG_GUESTAGENT_ARCH_ARMV7L=y
 CONFIG_GUESTAGENT_ARCH_PPC64LE=y
 CONFIG_GUESTAGENT_ARCH_RISCV64=y
 CONFIG_GUESTAGENT_ARCH_S390X=y
-CONFIG_GUESTAGENT_COMPRESS=n
+CONFIG_GUESTAGENT_COMPRESS=y

[kairveeehh]

@kairveeehh Do you want to open this PR?

diff --git a/Kconfig b/Kconfig
index d52d6fb0..7e40d787 100644
--- a/Kconfig
+++ b/Kconfig
@@ -47,4 +47,4 @@ config GUESTAGENT_COMPRESS
bool "guestagent compress"
help
Compress lima-guestagent

•   default n
  

•   default y
  

diff --git a/config.mk b/config.mk
index 9a02aae2..06ab7787 100644
--- a/config.mk
+++ b/config.mk
@@ -5,4 +5,4 @@ CONFIG_GUESTAGENT_ARCH_ARMV7L=y
CONFIG_GUESTAGENT_ARCH_PPC64LE=y
CONFIG_GUESTAGENT_ARCH_RISCV64=y
CONFIG_GUESTAGENT_ARCH_S390X=y
-CONFIG_GUESTAGENT_COMPRESS=n
+CONFIG_GUESTAGENT_COMPRESS=y

I would have not mind but amidst the situations in India , I am travelling as of now ( the flights are cancelled) so would suggest moving ahead if its required early.
thanks.

[AkihiroSuda]

Sure, hope you are in safe!

• Kconfig: set CONFIG_GUESTAGENT_COMPRESS=y by default #3529